id stringlengths 23 26 | content stringlengths 182 2.49k |
|---|---|
codereview_java_data_10 | return false;
}
- public boolean supportsFunction(RexCall call) {
return true;
}
Is the change to RexCall absolutely necessary? I don't want SqlDialect to depend on Rex or RelNode.
return false;
}
+ public boolean supportsFunction(SqlOperator operator, RelDataType type,
+ ... |
codereview_java_data_13 | List<String> folderServerIds = search.getFolderServerIds();
singleFolderMode = singleAccountMode && folderServerIds.size() == 1;
if (drawer == null) {
return;
} else if (singleFolderMode) {
This skips the last line of the method that seems unrelated to the drawer. My su... |
codereview_java_data_15 | public GlucoseStatus round() {
this.glucose = Round.roundTo(this.glucose, 0.1);
- this.noise = Round.roundTo(this.noise, 0.1);
this.delta = Round.roundTo(this.delta, 0.01);
this.avgdelta = Round.roundTo(this.avgdelta, 0.01);
this.short_avgdelta = Round.roundTo(this.short_... |
codereview_java_data_24 | TableMetadata updated = table.ops().current();
Integer updatedVersion = TestTables.metadataVersion("test");
Assert.assertEquals(current, updated);
- Assert.assertEquals(++currentVersion, updatedVersion.intValue());
// no-op commit due to no-op rename
table.updateSpec()
We don't use the retu... |
codereview_java_data_27 | private final Context context;
public static final String PREF_KEY_COUNTRY_CODE = "country_code";
public static final String PREFS = "CountryRegionPrefs";
-
public ItunesTopListLoader(Context context) {
this.context = context;
}
What do you think about only falling back to `US` when n... |
codereview_java_data_28 | TSERV_WAL_SORT_FILE_PREFIX("tserver.wal.sort.file.", null, PropertyType.PREFIX,
"The rfile properties to use when sorting logs during recovery. Most of the properties"
+ " that begin with 'table.file' can be used here. For example, to set the compression"
- + " of the sorted recovery files... |
codereview_java_data_31 | Iconify.with(new FontAwesomeModule());
SPAUtil.sendSPAppsQueryFeedsIntent(this);
-
- throw new NullPointerException();
}
}
pretty sure you didn't want to keep this in here...
Iconify.with(new FontAwesomeModule());
SPAUtil.sendSPAppsQueryFeedsIntent(this);
}
} |
codereview_java_data_35 | }
/**
- * Sets the used properties. Can be null if no properties should be used.
- * <p>
- * Properties are used to resolve ${variable} occurrences in the XML file.
*
- * @param properties the new properties
* @return the XmlJetConfigBuilder
*/
public XmlJetConfigBuilder... |
codereview_java_data_45 | Map<VariableNameDeclaration, List<NameOccurrence>> vars = node.getScope()
.getDeclarations(VariableNameDeclaration.class);
for (Map.Entry<VariableNameDeclaration, List<NameOccurrence>> entry : vars.entrySet()) {
- AccessNode accessNodeParent = entry.getKey().getAccessNodePa... |
codereview_java_data_48 | import java.util.OptionalInt;
import java.util.concurrent.CompletableFuture;
import io.vertx.core.Vertx;
import io.vertx.core.datagram.DatagramPacket;
import io.vertx.core.datagram.DatagramSocket;
Per style guild lambdas should be 1-3 lines.
import java.util.OptionalInt;
import java.util.concurrent.Completable... |
codereview_java_data_53 | SwipeRefreshLayout swipeRefreshLayout = root.findViewById(R.id.swipeRefresh);
swipeRefreshLayout.setOnRefreshListener(() -> {
AutoUpdateManager.runImmediate(requireContext());
- new Handler().postDelayed(() -> swipeRefreshLayout.setRefreshing(false), 1000);
});
... |
codereview_java_data_55 | + "scan is switched to that local file. We can not switch to the minor compacted file because it may have been modified by iterators. The file "
+ "dumped to the local dir is an exact copy of what was in memory."),
TSERV_BULK_PROCESS_THREADS("tserver.bulk.process.threads", "1", PropertyType.COU... |
codereview_java_data_57 | private String composedTaskRunnerName = "composed-task-runner";
@NotBlank
- private String schedulerTaskLauncher = "scheduler-task-launcher";
public String getComposedTaskRunnerName() {
return composedTaskRunnerName;
The name `schedulerTaskLauncher` implies the launcher itself instead of being the `name` of t... |
codereview_java_data_76 | public static final int WHITE = 8;
public static final int JELLIE = 9;
public static final int ALL_BLACK = 10;
}
These really need a private constructor to prevent instantiation.
public static final int WHITE = 8;
public static final int JELLIE = 9;
public static final int ALL_BLACK = 10;
+
+ private Cat... |
codereview_java_data_80 | protected void fetchColumns(final CommandLine cl, final ScannerBase scanner,
final ScanInterpreter formatter) throws UnsupportedEncodingException {
- if ((cl.hasOption(scanOptCfOptions.getOpt()) || cl.hasOption(scanOptColQualifier.getOpt()))
&& cl.hasOption(scanOptColumns.getOpt())) {
Strin... |
codereview_java_data_85 | if (posDeletes.stream().mapToLong(DeleteFile::recordCount).sum() < setFilterThreshold) {
return Deletes.filter(
records, this::pos,
- Deletes.toPositionSet(
- dataFile.path(),
- CloseableIterable.concat(deletes, ThreadPools.getWorkerPool(), ThreadPools.getPoolPa... |
codereview_java_data_89 | return scheduleTimeZone;
}
- @Schema(nullable = true, description = "A count limit of tasks to run for on-demand requests")
public Optional<Integer> getInstances() {
return instances;
}
this should be an addition, not a replacement. It functions as both, depending on the context of the request type... |
codereview_java_data_93 | int blockSize = (int) aconf.getAsBytes(Property.TABLE_FILE_BLOCK_SIZE);
try (
Writer small = new RFile.Writer(
- new BCFile.Writer(new RateLimitedOutputStream(fs.create(new Path(smallName)), null),
- "gz", conf, false, aconf),
blockSize);... |
codereview_java_data_102 | public static final CalciteSystemProperty<Boolean> TEST_SLOW =
booleanProperty("calcite.test.slow", false);
- /**
- * Whether to do validation within VolcanoPlanner after each rule firing.
- * Note that doing so would significantly slow down the planning. Should only
- * enable for unit test.
- */
- ... |
codereview_java_data_114 | @DatabaseField
public boolean isSMB = false;
public Treatment() {
}
I'd prefer to keep it. It's not done yet but it's prepared for supporting multiple insulin types with MDI or pump+MDI
@DatabaseField
public boolean isSMB = false;
+ @DatabaseField
+ public int insulinInterfaceID = ... |
codereview_java_data_120 | }
recordSchema = Schema.createRecord(recordName, null, null, false, fields);
- if (struct.isUnionSchema()) {
recordSchema.addProp(AvroSchemaUtil.UNION_SCHEMA_TO_RECORD, true);
}
results.put(struct, recordSchema);
Is there some reason why this needs to be a round-trip conversion? I think i... |
codereview_java_data_144 | public abstract Address[] getRecipients(RecipientType type) throws MessagingException;
- public abstract Address[] getListPost();
-
public abstract void setRecipients(RecipientType type, Address[] addresses)
throws MessagingException;
Please don't add more utility methods to `Message`. Instead you co... |
codereview_java_data_151 | @javax.inject.Inject
public ApplicationConfig(
Instance<org.kie.kogito.KogitoConfig> configs) {
- super($Addons$, configs.stream().toArray(org.kie.kogito.KogitoConfig[]::new));
}
}
\ No newline at end of file
same note about using an overloaded constructor for `StaticApplication` wi... |
codereview_java_data_154 | return new UncommittedIterator<>(this, from, to, false, forEntries);
case REPEATABLE_READ:
case SERIALIZABLE:
- return transaction.hasChanges() ?
- new RepeatableIterator<K, X>(this, from, to, forEntries) :
- new Com... |
codereview_java_data_165 | return new UidFetchCommand.Builder()
.maximumAutoDownloadMessageSize(maximumAutoDownloadMessageSize)
.idSet(Collections.singletonList(uid))
- .messageParams(fetchProfile, new HashMap<>(Collections.singletonMap(String.valueOf(uid),
- (Messa... |
codereview_java_data_167 | public String getLogFileParentDir() {
ArrayList<String> elements = new ArrayList<String>();
- if(mPrefix.length() > 0) {
elements.add(mPrefix);
}
- if(mTopic.length() > 0) {
elements.add(mTopic);
}
return StringUtils.join(elements, "/");
... |
codereview_java_data_175 | public List<RoleInfo> getRoles(String username) {
List<RoleInfo> roleInfoList = roleInfoMap.get(username);
- if (!authConfigs.isCachingEnabled() || roleInfoList == null) {
Page<RoleInfo> roleInfoPage = getRolesFromDatabase(username, DEFAULT_PAGE_NO, Integer.MAX_VALUE);
if ... |
codereview_java_data_180 | */
package org.flowable.scripting.secure.impl;
import org.flowable.variable.api.delegate.VariableScope;
import org.mozilla.javascript.Context;
import org.mozilla.javascript.Scriptable;
-import java.util.Map;
-
/**
* @author Joram Barrez
*/
Project standards are to place `java` imports before `org` imports. ... |
codereview_java_data_193 | } else if (getSupportFragmentManager().findFragmentByTag(nearbyFragmentTag) != null && !isContributionsFragmentVisible) {
// Means that nearby fragment is visible (not contributions fragment)
NearbyParentFragment nearbyFragment = (NearbyParentFragment) contributionsActivityPagerAdapte... |
codereview_java_data_197 | protected Catalog createCatalog(String name, Map<String, String> properties, Configuration hadoopConf) {
CatalogLoader catalogLoader = createCatalogLoader(name, properties, hadoopConf);
String defaultDatabase = properties.getOrDefault(DEFAULT_DATABASE, "default");
- boolean cacheEnabled = Boolean.parseB... |
codereview_java_data_208 | }
return objectMapper.readValue(response.getResponseBodyAsStream(), MESOS_FILE_OBJECTS);
- } catch (ExecutionException | ConnectException ce) {
throw new SlaveNotFoundException(ce);
} catch (Exception e) {
- throw Throwables.propagate(e);
}
}
the issue it that `ConnectExceptio... |
codereview_java_data_235 | Types.NestedField.optional(icebergID, name, type);
}
- private static class OrcToIcebergVisitor extends OrcSchemaWithTypeVisitor<Optional<Types.NestedField>> {
private final Map<Integer, OrcField> icebergToOrcMapping;
Would it make sense to define an `OrcSchemaVisitor` visitor, similar to `org.apache... |
codereview_java_data_237 | import static org.assertj.core.api.Assertions.assertThat;
import tech.pegasys.pantheon.consensus.ibft.ibftmessage.CommitMessage;
import tech.pegasys.pantheon.consensus.ibft.ibftmessage.NewRoundMessage;
import tech.pegasys.pantheon.consensus.ibft.ibftmessage.PrepareMessage;
import tech.pegasys.pantheon.consensus.ib... |
codereview_java_data_238 | Column column = table.getColumn(columnName);
columnsToRemove.add(column);
} while (readIf(","));
- readIf(")"); // For Oracle compatibility - close bracket
command.setTableName(tableName);
command.setIfTableExist... |
codereview_java_data_240 | <h1>Error 503 Backend is unhealthy</h1>
<p>Backend is unhealthy</p>
<h3>Guru Mediation:</h3>
- <p>Details: cache-sea4456-SEA 1645539068 1201284252</p>
<hr>
<p>Varnish cache server</p>
</body>
I don't quite like that the responsibility for executing the actual call on the `ImapConnection`... |
codereview_java_data_242 | @RunWith(HazelcastSerialClassRunner.class)
public class JetInstanceTest extends JetTestSupport {
- private static final String UNABLE_CONNECTION_MESSAGE = "Unable to connect";
@Rule
public ExpectedException expectedException = ExpectedException.none();
should be `UNABLE_TO_CONNECT_MESSAGE`
@RunWith(Ha... |
codereview_java_data_247 | * @param callback the callback {@link Consumer}
* @return the callback to enable fluent programming
*/
- public Consumer<Value<T>> onSetNextValue(Consumer<Value<T>> callback);
/**
* Removes an onSetNextValue callback.
There should be a corresponding add method
* @param callback the callback {@link Co... |
codereview_java_data_249 | * Multiplies one mapping by another.
*
* <p>{@code multiply(A, B)} returns a mapping C such that A . B (the mapping
- * B followed by the mapping A) is equivalent to C.
*
* @param mapping1 First mapping
* @param mapping2 Second mapping
It should be "the mapping A followed by the mapping B"?
... |
codereview_java_data_255 | * the pipeline aborted.
*
* <p>In most cases a Pipe is used through one of two narrower interfaces it supports {@link
- * InputPipe} and {@link OutputPipe}. These are designed to expose only the operations relevant to
* objects either reading from or publishing to the pipe respectively.
*
* @param <T> the t... |
codereview_java_data_256 | this.serialized = serialized;
}
- MaterialColor(int color500, int color900, int color700, String serialized) {
- this(color500, color500, color700, color700, color700, color900, serialized);
}
public int toConversationColor(@NonNull Context context) {
not down with the renaming, the class... |
codereview_java_data_281 | return offers;
}
@Override
public void returnOffer(OfferID offerId) {
synchronized (offerCache) {
Saw a sentry come through for this the other day. This exception will bubble all the way back up to the LeaderOnlyPoller and cause us to abort. Should we maybe catch this and just skip the offer in the ... |
codereview_java_data_282 | }
public static final String MESSAGE_PARTS_MARKER = "_|_";
- public static Pattern MESSAGE_PARTS_MARKER_REGEX = Pattern.compile("_\\|_");
@Override
public void setMessage(String[] messageParts) {
I guess this should be final too?
}
public static final String MESSAGE_PARTS_MARKER = "_|... |
codereview_java_data_283 | private boolean isPortInUse(int port) {
try {
- new Socket("127.0.0.1", port).close();
- return true;
} catch(IOException e) {
// Could not connect.
}
- return false;
}
private SingularityTaskExecutorData readExecutorData(ObjectMapper objectMapper, Protos.TaskInfo taskInfo) {... |
codereview_java_data_284 | this.store = new Iterable<TabletLocationState>() {
@Override
public Iterator<TabletLocationState> iterator() {
- return Iterators.concat(new RootTabletStateStore(context).iterator(),
- new MetaDataStateStore(context).iterator());
}
};
}
Could call `liveServers.scanSe... |
codereview_java_data_301 | this.threadChecker = threadChecker;
this.threadChecker.start(this);
- this.requestManager = requestManager;
- this.deployManager = deployManager;
- this.taskManager = taskManager;
-
this.tasks = Maps.newConcurrentMap();
this.processBuildingTasks = Maps.newConcurrentMap();
this.processR... |
codereview_java_data_302 | * Instantiates an action to remove all the files reachable from given metadata location.
*/
default RemoveReachableFiles removeReachableFiles(String metadataLocation) {
- throw new UnsupportedOperationException(this.getClass().getName() + " does not implement" +
- " removeReachableFiles");
}
}
... |
codereview_java_data_304 | *
* @param forUpdateRows the rows to lock
*/
- public void lockRows(Iterator<Row> forUpdateRows) {
table.lockRows(session, forUpdateRows);
}
From my point of view It's better to preserve `ArrayList<Row>` here and change singature of `Table.lockRows()` to the `(Session, ArrayList<Row>... |
codereview_java_data_311 | .url(urlBuilder.toString())
.build();
Response response = okHttpClient.newCall(request).execute();
- if (response.body() != null && response.isSuccessful()) {
String json = response.body().string();
return gson.fromJson(... |
codereview_java_data_312 | templates.add(templateName);
}
TemplateMetaData templateMeta = new TemplateMetaData();
templateMeta.setCurrentVersion(templateMetaData.getLatestVersion());
templateMetalist.add(templateMeta);
domainStruct.setTemplateMeta(templateMetalist);
this implementation d... |
codereview_java_data_313 | private final Address recipient;
private final VoteType voteType;
public static final ImmutableBiMap<VoteType, Byte> voteToValue =
ImmutableBiMap.of(
- VoteType.ADD, (byte) 0xFF,
- VoteType.DROP, (byte) 0x0);
public Vote(final Address recipient, final VoteType voteType) {
this.... |
codereview_java_data_321 | @NeedAuth
@GetMapping("/datum")
- public String get(@RequestParam(name = "keys") String keysString,HttpServletRequest request, HttpServletResponse response) throws Exception {
response.setHeader("Content-Type", "application/json; charset=" + getAcceptEncoding(request));
response.setHeader... |
codereview_java_data_329 | * @deprecated since 2.0.0, replaced by {@link Accumulo#newClient()}
*/
@Deprecated
-public class ClientConfiguration extends CompositeConfiguration {
private static final Logger log = LoggerFactory.getLogger(ClientConfiguration.class);
public static final String USER_ACCUMULO_DIR_NAME = ".accumulo";
This we... |
codereview_java_data_336 | public long getTimestamp() {
return timestamp;
}
-
- public String toJson() {
- try {
- return new ObjectMapper().writeValueAsString(this);
- } catch (JsonProcessingException e) {
- throw new RuntimeException(e);
- }
- }
}
To be removed? I don't see ... |
codereview_java_data_338 | /**
* Before moving next check if the required feilds are empty
- * */
-
public boolean areRequiredFieldsEmpty() {
if (mImageUrl == null || mImageUrl.equals("")) {
- Toast.makeText(OFFApplication.getInstance(), R.string.add_at_least_one_picture, Toast.LENGTH_SHORT).show();
- ... |
codereview_java_data_339 | }
public InclusiveMetricsEvaluator(Schema schema, Expression unbound, boolean caseSensitive) {
- final StructType struct = schema.asStruct();
this.expr = Binder.bind(struct, rewriteNot(unbound), caseSensitive);
}
Can you remove the unnecessary `final`?
}
public InclusiveMetricsEvaluator(Schema ... |
codereview_java_data_342 | }
}
- private boolean isCacheUpToDate(final RuleContext context) {
- return configuration.getAnalysisCache().isUpToDate(context.getSourceCodeFile());
- }
-
- private Iterable<RuleViolation> getCachedViolationsForFile(final File sourceCodeFile) {
- return configuration.getAnalysisCac... |
codereview_java_data_354 | public static void outputShellVariables(Map<String,String> config, PrintStream out) {
for (String section : SECTIONS) {
if (config.containsKey(section)) {
- out.printf((PROPERTY_FORMAT) + "%n", section.toUpperCase() + "_HOSTS", config.get(section));
} else {
if (section.equals("man... |
codereview_java_data_358 | }
private void reset() {
existingManifests.clear();
processedManifests.clear();
newManifests.clear();
By clearing `newManifests`, this loses track of any any manifests that were written by a previous call to `performRewrite`. Those should be deleted instead. Could you run `cleanAll` at the start o... |
codereview_java_data_376 | @Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
- ApplicationlessInjection
- - .getInstance(getActivity().getApplicationContext())
- - .getCommonsApplicationComponent()
- - .inject(this);
... |
codereview_java_data_380 | @Test
public void shouldLimitNumberOfResponsesToNodeDataRequests() throws Exception {
- new EthServer(
- blockchain,
- worldStateArchive,
- ethMessages,
- EthServer.DEFAULT_REQUEST_LIMIT,
- EthServer.DEFAULT_REQUEST_LIMIT,
- EthServer.DEFAULT_REQUEST_LIMIT,
- Et... |
codereview_java_data_382 | intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
intent.putExtra(Intent.EXTRA_STREAM, fileUri);
intent.setType("image/png");
- startActivity(Intent.createChooser(intent, getString(R.string.achiev_activity_share_screen)));
} catch (IOException e) {
e... |
codereview_java_data_390 | break;
case KeyEvent.KEYCODE_B:
case KeyEvent.KEYCODE_T:
- OnKeyListenerForFragments myFragment =
- (OnKeyListenerForFragments) getSupportFragmentManager()
- .findFragmentById(R.id.main_view);
- ... |
codereview_java_data_395 | .withCommand("-t4 -c128 -d100s http://frontend:8081 --latency");
startContainer(wrk);
- LOGGER.info("Benchmark started.");
if (zipkin != null) {
printContainerMapping(zipkin);
}
is the logger helping us? seems to add a bunch of redundant formatting :)
.withCommand("-t4 -c128 -d1... |
codereview_java_data_396 | */
@Override
public int compare(SearchResult o1, SearchResult o2) {
- if(o1.getComponent() instanceof FeedItem && o2.getComponent() instanceof FeedItem){
return ((FeedItem) o2.getComponent()).getPubDate().compareTo(((FeedItem) o1.getComponent()).getPubDate());
}
ret... |
codereview_java_data_404 | -/**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
-/* Generated By:JJTree: Do not edit this line. ASTDeclaration.java */
package net.sourceforge.pmd.lang.jsp.ast;
public class ASTDeclaration extends AbstractJspNode {
private String name;
`setName()` can be package-privat... |
codereview_java_data_407 | private final String canonical;
protected AbstractId(final String canonical) {
- if (canonical == null || canonical.trim().isEmpty())
- throw new IllegalArgumentException("Id string provided can't be empty or null.");
- this.canonical = canonical;
}
/**
Since the parameter name is "canonical", i... |
codereview_java_data_411 | /**
* Return the current schema version for the host.
* <p/>
- * Schema versions in Cassandra are used to insure all the nodes agree on the current
* Cassandra schema when it is modified. For more information see {@link ExecutionInfo#isSchemaInAgreement()}
*
* @return the node's c... |
codereview_java_data_419 | int theme = getTheme();
if (theme == R.style.Theme_AntennaPod_Dark) {
return R.style.Theme_AntennaPod_Dark_NoTitle;
- }else if (theme == R.style.Theme_AntennaPod_TrueBlack){
return R.style.Theme_AntennaPod_TrueBlack_NoTitle;
} else {
return R.styl... |
codereview_java_data_420 | package software.amazon.awssdk.regions;
/**
* Metadata about a partition such as aws or aws-cn.
*
* <p>This is useful for building meta-functionality around AWS services. Partition metadata helps to provide
* data about regions which may not yet be in the endpoints.json file but have a specific prefix.</p>
... |
codereview_java_data_429 | case "Long":
return currentNode.asLong();
case "Short":
- return (short) currentNode.asDouble();
case "Integer":
return currentNode.asInt();
case "String":
Query :Why asDouble and not .asInt(); ?
case ... |
codereview_java_data_431 | import software.amazon.awssdk.annotations.SdkPublicApi;
import software.amazon.awssdk.core.batchmanager.BatchOverrideConfiguration;
import software.amazon.awssdk.services.sqs.SqsAsyncClient;
-import software.amazon.awssdk.services.sqs.internal.batchmanager.DefaultSqsAsyncBatchManager;
import software.amazon.awssdk.... |
codereview_java_data_444 | try {
negativeTtl = Integer.parseInt(Security.getProperty("networkaddress.cache.negative.ttl"));
} catch (NumberFormatException exception) {
- log.warn("Failed to get JVM negative DNS responses cache TTL due to format problem "
+ "(e.g. this JVM might not have the property). "
... |
codereview_java_data_454 | LocalRepository localRepo = new LocalRepository(localRepoPath);
session.setLocalRepositoryManager(system.newLocalRepositoryManager(session, localRepo));
session.setOffline(this.offline);
- if (this.mavenProperties != null && this.mavenProperties.getConnectTimeout() > 0) {
- session.setConfigProperty("aether... |
codereview_java_data_460 | @BindView(R.id.contributionSequenceNumber) TextView seqNumView;
@BindView(R.id.contributionProgress) ProgressBar progressView;
@BindView(R.id.failed_image_options) LinearLayout failedImageOptions;
- @BindView(R.id.failed_image_options_retry) LinearLayout failedImageOptionsretry;
private Displayab... |
codereview_java_data_462 | // variable
private volatile boolean enable = SystemConfig.getInstance().getEnableStatistic() == 1;
- private volatile int statisticTableSize = SystemConfig.getInstance().getStatisticTableSize();
private int statisticQueueSize = SystemConfig.getInstance().getStatisticQueueSize();
private Statisti... |
codereview_java_data_467 | * This class was copied from Guava release 23.0 to replace the older Guava 14 version that had been used in Accumulo.
* It was annotated as Beta by Google, therefore unstable to use in a core Accumulo library. We learned this the hard
* way when Guava version 20 deprecated the getHostText method and then removed... |
codereview_java_data_469 | media.generateThumbnail(inputFile, getFormat(), getType(), seekPosition, isResume(), renderer);
if (!isResume() && media.getThumb() != null && configurationSpecificToRenderer.getUseCache() && inputFile.getFile() != null) {
- Connection connection = null;
- try {
- connection = MediaDatabase.getConnect... |
codereview_java_data_475 | import org.apache.accumulo.harness.AccumuloClusterHarness;
import org.junit.After;
import org.junit.Test;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import com.google.common.collect.Iterables;
public class AccumuloClientIT extends AccumuloClusterHarness {
- Logger log = LoggerFactory.getLogger(Acc... |
codereview_java_data_477 | + qualifiedName.substring(qualifiedName.lastIndexOf('.') + 1);
try {
myType = pmdClassLoader.loadClass(qualifiedNameInner);
- } catch (Exception ignored) {
// ignored, we'll try again with a different package name/fqcn
} catch (... |
codereview_java_data_483 | * @see SummarizerConfiguration#getOptions()
*/
public Builder addOptions(Map<String,String> options) {
- options.forEach((key, value) -> addOption(key, value));
return this;
}
You can even go a step further with this one: ```suggestion options.forEach(this::addOption); ```
* @s... |
codereview_java_data_489 | taskId.getId()
);
purgeFromZk(taskId);
}
- LOG.error("Task ID {} too long to pesist to DB, skipping", taskId.getId());
} else {
if (moveToHistoryOrCheckForPurge(taskId, forRequest)) {
LOG.debug(... |
codereview_java_data_495 | }
public BaseVectorizedParquetValuesReader(int bitWidth, int maxDefLevel, boolean setValidityVector) {
- this.fixedWidth = true;
- this.readLength = bitWidth != 0;
- this.maxDefLevel = maxDefLevel;
- this.setArrowValidityVector = setValidityVector;
- init(bitWidth);
}
public BaseVectorizedPar... |
codereview_java_data_500 | private @Nullable Recipients conversationRecipients;
private @NonNull Stub<ThumbnailView> mediaThumbnailStub;
private @NonNull Stub<AudioView> audioViewStub;
private @NonNull ExpirationTimerView expirationTimer;
private int defaultBubbleColor;
- private int sentTextPrimColor;
private ... |
codereview_java_data_508 | System.exit(1);
}
- String name ="sampleQuery" ; //args[0];
AthenaClient athenaClient = AthenaClient.builder()
.region(Region.US_WEST_2)
.build();
Did you intend to ignore the command line arg?
System.exit(1);
}
+ St... |
codereview_java_data_509 | manifest -> Objects.equal(manifest.snapshotId(), snapshotId));
try (CloseableIterable<ManifestEntry> entries = new ManifestGroup(ops, changedManifests)
.ignoreExisting()
- .select("file_path", "file_format", "partition", "record_count", "file_size_in_bytes")
.entries()) {
f... |
codereview_java_data_510 | }
}
private void askDexterToHandleExternalStoragePermission() {
Timber.d(TAG, "External storage permission is being requested");
if (null == dexterStoragePermissionBuilder) {
Please don't split this line, it does not improve readability. :)
}
}
+ /**
+ * This ... |
codereview_java_data_515 | @CliOption(mandatory = true, key = {
"expression" }, help = "the cron expression of the schedule") String expression,
@CliOption(key = {
- PROPERTIES_OPTION }, help = "a task properties (coma separated string eg.: --properties 'prop.first=prop,prop.sec=prop2'") String properties,
@CliOption(key = ... |
codereview_java_data_522 | holder.placeTypeLayout.setBackgroundColor(label.isSelected() ? ContextCompat.getColor(context, R.color.divider_grey) : Color.WHITE);
NearbyParentFragmentPresenter.getInstance().filterByMarkerType(selectedLabels);
});
-
- //TODO: recover current location marker if selection is e... |
codereview_java_data_527 | }
private AuthenticationException onError(JwtException e) {
- if (logger.isDebugEnabled()) {
- logger.debug("Authentication error for Jwt Token: " + e.getMessage());
- }
if (e instanceof BadJwtException) {
return new InvalidBearerTokenException(e.getMessage(), e);
} else {
I'm not seeing the added be... |
codereview_java_data_528 | if (isSupported(dmnType)) {
Optional<AbstractDmnType> type = supportedDmnTypes.stream().filter(x -> x.getDmnType().equalsIgnoreCase(dmnType)).findFirst();
if (type.isPresent()) {
- return Optional.of(type.get().getGrafanaFunction());
}
}
r... |
codereview_java_data_542 | if ((method != LoadBalancerMethod.CHECK_STATE && method != LoadBalancerMethod.PRE_ENQUEUE) &&
result.state == BaragonRequestState.FAILED
- && result.message.orElse("").contains("is already enqueued with different parameters")) {
LOG.info("Baragon request {} already in the queue, will fetch c... |
codereview_java_data_543 | @Test
public void shouldCollectDefinedValueUsingPartialFunction() {
- final PartialFunction<Integer, String> pf = new PartialFunction<Integer, String>() {
- @Override
- public String apply(Integer i) {
- return String.valueOf(i);
- }
- @Overrid... |
codereview_java_data_556 | if (!compress) {
return encode();
}
-
ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
DeflaterOutputStream outputStream = new DeflaterOutputStream(byteArrayOutputStream, new Deflater(Deflater.BEST_COMPRESSION));
DataVersion dataVersion... |
codereview_java_data_559 | private static final String NAMESPACE = "default";
- // Error message
- private static final String OUTPUT_DIFFERENT_ERROR_MSG =
- "Output data different between iceberg and non-iceberg table";
-
@Parameterized.Parameters(name = "Catalog Name {0} - Options {2}")
public static Object[][] parameters() {
... |
codereview_java_data_568 | this.configuration = configuration;
this.exceptionNotifier = exceptionNotifier;
- this.checkFileOpenLock = new ReentrantLock();
}
protected abstract void uploadSingle(int sequence, Path file) throws Exception;
Just checking, is this class always a singleton? Want to make sure we aren't just creating... |
codereview_java_data_570 | // check rogue syntax in spec module
Set<Sentence> toCheck = mutable(specModule.sentences().$minus$minus(mainDefModule.sentences()));
for (Sentence s : toCheck)
- if (s instanceof Production || s instanceof SyntaxSort || s instanceof SyntaxLexical ||
- s instance... |
codereview_java_data_571 | staticFromMap.addStatement(new AssignExpr(nameField, new NameExpr("name"), AssignExpr.Operator.ASSIGN));
for (Entry<String, String> entry : humanTaskNode.getInMappings().entrySet()) {
- Variable variable = variableScope.findVariable(entry.getValue());
if (variable == null) {
- ... |
codereview_java_data_575 | public static final String COMMIT_TOTAL_RETRY_TIME_MS = "commit.retry.total-timeout-ms";
public static final int COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT = 1800000; // 30 minutes
- public static final String COMMIT_NUM_STATUS_CHECKS = "commit.num-status-checks";
public static final int COMMIT_NUM_STATUS_CHECKS_DEFA... |
codereview_java_data_581 | if(currentProfile == null)
return;
if(currentProfile.getUnits().equals(Constants.MMOL))
- tt = prefTT > 0 ? Profile.toMgdl(prefTT, Constants.MGDL) : 80d;
else
tt = prefTT > 0 ? prefTT : 80d;
final double finalTT = tt;... |
codereview_java_data_583 | return typeDeclaration;
}
- @Override
- protected boolean useApplication() {
- return false;
- }
-
private void populateStaticKieRuntimeFactoryFunctionInit(ClassOrInterfaceDeclaration typeDeclaration) {
final InitializerDeclaration staticDeclaration = typeDeclaration.getMembe... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.